Skip to content

Prepare r1.1 v0.5.0-rc.1#16

Merged
Kevsy merged 13 commits intocamaraproject:mainfrom
maheshc01:release3.1-rc
Jul 29, 2025
Merged

Prepare r1.1 v0.5.0-rc.1#16
Kevsy merged 13 commits intocamaraproject:mainfrom
maheshc01:release3.1-rc

Conversation

@maheshc01
Copy link
Contributor

@maheshc01 maheshc01 commented Jul 3, 2025

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Creating the release candidate for Fall 25

Which issue(s) this PR fixes:

Fixes #17
Alignment with latest commonalities and ICM guidelines.

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@maheshc01 maheshc01 requested review from Kevsy and urvika-v as code owners July 3, 2025 00:17
@maheshc01 maheshc01 marked this pull request as draft July 3, 2025 00:18
@maheshc01
Copy link
Contributor Author

change log has not been updated yet. will do it after the other issue #15 is complete

@maheshc01
Copy link
Contributor Author

all the open issues have been closed in this repo.
Have updated the changelog based on all the latest changes.
Please note that i have use r1.1 for this release candidate as this is the first release in the new repo created for application profiles. I used device status repo as reference for taking this approach.

@maheshc01 maheshc01 marked this pull request as ready for review July 15, 2025 15:00
@maheshc01 maheshc01 requested a review from a team as a code owner July 15, 2025 15:00
@hdamker hdamker changed the title Prepare v0.5.0-rc1 Prepare r1.1 v0.5.0-rc.1 Jul 15, 2025
@rartych
Copy link
Contributor

rartych commented Jul 18, 2025

Critical Issues Requiring Immediate Attention

 externalDocs:
  description: Product documentation at CAMARA
  url: https://github.com/camaraproject/{apiRepository}
 # {apiRepository} MUST be replaced by the CAMARA API Repository name where the API specification is hosted.

@urvika-v
Copy link
Contributor

@rartych @hdamker @Kevsy
I have addressed the critical issues raised. Could you please review.

@rartych
Copy link
Contributor

rartych commented Jul 21, 2025

@urvika-v Thank you - there are no more critical issues - I'll continue the review.

Quick fix: The Readiness checklist needs to be updated to the template:
https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API-Readiness-Checklist.md

@urvika-v
Copy link
Contributor

@rartych Updated API-Readiness-Checklist

@rartych
Copy link
Contributor

rartych commented Jul 22, 2025

I think the first line in the Release Information section in README.md will be outdated after r1.1 .
The simplest solution is to uncomment the lines already present in the file and place them in the right places:

<!-- Pre-releases of this sub project are available in https://github.com/camaraproject/ApplicationProfiles/releases -->

<!-- For changes see [CHANGELOG.md](https://github.com/camaraproject/ApplicationProfiles/blob/main/CHANGELOG.md) -->

BTW, More detailed template for this section is expected for M4.

Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
@rartych
Copy link
Contributor

rartych commented Jul 22, 2025

In API-Readiness-Checklist

|  2 | Design guidelines from Commonalities applied |   O   |         M         |    M    |    M   | Y  |  r3.2    |
|  3 | Guidelines from ICM applied                  |   O   |         M         |    M    |    M   | Y    |  r3.2  |

links to Commonalites and ICM release are expected:

|  2 | Design guidelines from Commonalities applied |   O   |         M         |    M    |    M   |   Y   |  [r3.2](https://github.com/camaraproject/Commonalities/releases/tag/r3.2)     |
|  3 | Guidelines from ICM applied                  |   O   |         M         |    M    |    M   |   Y   |  [r3.2](https://github.com/camaraproject/IdentityAndConsentManagement/releases/tag/r3.2)     |

@rartych
Copy link
Contributor

rartych commented Jul 22, 2025

Is error

            GENERIC_404_IDENTIFIER_NOT_FOUND:
              description: Some identifier cannot be matched to a device
              value:
                status: 404
                code: IDENTIFIER_NOT_FOUND
                message: Device identifier not found

relevant for this API? If so maybe the description and message can be updated - this can be discussed and addressed by the team before M4

Similarly:

            GENERIC_403_INVALID_TOKEN_CONTEXT:
              description: Reflect some inconsistency between information in
                some field of the API and the related OAuth2 Token
              value:
                status: 403
                code: INVALID_TOKEN_CONTEXT
                message: "{{field}} is not consistent with access token."

urvika-v and others added 2 commits July 22, 2025 23:09
…ness-Checklist.md

Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
urvika-v and others added 2 commits July 22, 2025 23:15
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
@rartych
Copy link
Contributor

rartych commented Jul 23, 2025

@urvika-v Almost done!
Please include the correction in changelog and address #16 (comment).

Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
@rartych
Copy link
Contributor

rartych commented Jul 28, 2025

Please check the README.md as indicated in #16 (comment)

@maheshc01
Copy link
Contributor Author

section is expected for M4.

@rartych readme has been update. let me know if this looks good.

@rartych rartych self-requested a review July 29, 2025 09:27
Copy link
Contributor

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Release Management perspective

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved as codeowner.

@Kevsy Kevsy merged commit 7b160a2 into camaraproject:main Jul 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create r1.1 for Fall 25

4 participants